Update to retreave magnetic field only once per run#1076
Merged
Conversation
lauraser
requested review from
alibuild,
jgrosseo,
saganatt and
victor-gonzalez
as code owners
| // TODO done only once (and not per run). Will be replaced by CCDBConfigurable | ||
| static o2::parameters::GRPObject* grpo = nullptr; | ||
| if (grpo == nullptr) { | ||
| grpo = ccdb->getForTimeStamp<o2::parameters::GRPObject>("GLO/GRP/GRP", timestamp); |
Collaborator
There was a problem hiding this comment.
Have in mind that for Run 3 data the CCDB endpoint and the layout of the magnetic field information has changed
You will need to consider that if you address JUN Pilot beam data and/or Run 3 data
| // TODO done only once (and not per run). Will be replaced by CCDBConfigurable | ||
| static o2::parameters::GRPObject* grpo = nullptr; | ||
| if (grpo == nullptr) { | ||
| grpo = ccdb->getForTimeStamp<o2::parameters::GRPObject>("GLO/GRP/GRP", timestamp); |
Collaborator
There was a problem hiding this comment.
Same comment as above
| // TODO done only once (and not per run). Will be replaced by CCDBConfigurable | ||
| static o2::parameters::GRPObject* grpo = nullptr; | ||
| if (grpo == nullptr) { | ||
| grpo = ccdb->getForTimeStamp<o2::parameters::GRPObject>("GLO/GRP/GRP", timestamp); |
Collaborator
There was a problem hiding this comment.
Same comment as above
victor-gonzalez
approved these changes
Jul 28, 2022
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Consider my comments if you plan to access Run 3 data at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.